Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry name improvements #4764

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Telemetry name improvements #4764

merged 2 commits into from
Jul 4, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 3, 2024 •
edited by dotnet-policy-service bot

  • Remove instance ID from uninstrumented peer names when not needed
  • Shorten guid display to the first 8 characters. It's common for the instance ID to be a guid and this can make names in the UI look messy. A shortened name is more user friendly.
Microsoft Reviewers: Open in CodeFlow

radical
radical reviewed Jul 3, 2024
View reviewed changes
src/Aspire.Dashboard/Otlp/Model/OtlpApplication.cs
Comment on lines +204 to +199
// Before: aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee
// After: aaaaaaaa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the example!

@JamesNK JamesNK force-pushed the jamesnk/telemetryinstanceid-fixes branch from 5fd91e2 to 720817b Compare July 3, 2024 23:29
@JamesNK JamesNK enabled auto-merge (squash) July 3, 2024 23:29
@JamesNK
Copy link
Member Author

JamesNK commented Jul 4, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK force-pushed the jamesnk/telemetryinstanceid-fixes branch from 4150d3c to ef03add Compare July 4, 2024 02:29
@JamesNK JamesNK force-pushed the jamesnk/telemetryinstanceid-fixes branch from ef03add to 6ce7e87 Compare July 4, 2024 02:29
@JamesNK JamesNK merged commit 2249f7d into main Jul 4, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/telemetryinstanceid-fixes branch July 4, 2024 03:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical left review comments

@adamint adamint adamint approved these changes

@drewnoakes drewnoakes Awaiting requested review from drewnoakes

@tlmii tlmii Awaiting requested review from tlmii

@kvenkatrajan kvenkatrajan Awaiting requested review from kvenkatrajan

Assignees
No one assigned
Labels
area-dashboard area-telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamesNK @radical @adamint