-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS CDK support #2225
Open
vlesierse
wants to merge
38
commits into
dotnet:main
Choose a base branch
from
vlesierse:vlesierse/aws-cdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add AWS CDK support #2225
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b97fd81
Initial AWS CDK Support
a3ecee3
Add documentation and additional resources
6164785
Make properties optional
77d56cb
Add Amazon Kinesis streams
306e022
Merge branch 'main' into vlesierse/aws-cdk
756fea0
Add bucket notifications and topic subscriptions
be9136a
Adding this for extension methods
925b358
Fix await stack resource
vlesierse 6120522
Allow multiple reference to same construct resource
vlesierse 953c11e
Merge branch 'main' into vlesierse/aws-cdk
vlesierse e74cbf0
Refactoring after code review
f54ee37
Cleanup
4063577
Changes after code review
c606bb3
Provide guidance for missing CDK bootstrap
4cf0b37
Merge AWSCDK in AWS playground
4b6ae98
Merge branch 'main' into vlesierse/aws-cdk
98feb7e
Merge branch 'main' into vlesierse/aws-cdk
6ff3a61
Changes after code review
9668b80
Remove support restrictions
38433e6
Simplified construct/stack outputs
e691101
Include output changes
2b25719
Introduce new provisioners
9f71622
CloudFormation provisioners
vlesierse 2a4d1e9
Refactor CloudFormation executor
77ef4ec
Add AWS CDK Provisioning
vlesierse e7e50d5
Change manifest to include the right stack name
vlesierse bc5daa1
Fix manifest values
vlesierse 6850b46
Support dev environments with spaces
vlesierse 29cebe5
Add tests for CDK resources
95f55af
Add CDK documentation to README.md
9329a9c
Changes after code review
821a6cf
Changes after code review
910e762
Additional changes after code review
dd45fb9
Refactor and simplify CDK stack provisioning
98e94ba
Merge branch 'main' into vlesierse/aws-cdk
6ce231a
Remove AWSSDK SSO
4e9338a
Fix build
04f0571
Merge branch 'main' into vlesierse/aws-cdk
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make properties optional
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By putting the extension method on
IResourceWithConstruct
the method shows up more then makes sense. For example when I call theAddDynamoDBTable
to create a DDB table intellisense then showsAddSQSQueue
as a method off of the table which is really confusing to look like you can add a queue to a table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a CDK perspective it allowed to add a Queue construct to a DynamoDB Table, but I agree it introduces confusion and false expectations. I'll change this to only accept the
IResourceBuilder<IStackResource>
so it can only be add to a stack. If the user want to do this to a construct, they can use theAddConstruct
method.