GlfwNativeWindow: Allow wayland window ptr to be read when GLFW is compiled with both X11 and Wayland #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpiled with both X11 and Wayland
|
Nitpick: Methinks you should actually check the error code for GLFW_PLATFORM_UNAVAILABLE instead of just relying on the only possible errors being a sign that X11 is not to be used. Besides that LGTM |
Perksey
deleted the
hotfix/fix-glfw-native-window-handles-LOLNathaniel-Scuttlebug-Paragoomba-Two-Legged-Black-Haired-Singularity-Three-Legged-Master-Roshi-Koopa-the-Quick-Everytime-Sometimes-Once-in-a-While
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Currently if wayland is used we say its X11 with no window or display ptr