Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Apple Silicon for CI #1693

Merged
merged 31 commits into from
Oct 10, 2023
Merged

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Oct 2, 2023

No description provided.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@Perksey
Copy link
Member Author

Perksey commented Oct 6, 2023

Pinged (pung?) a message to Chris S to see whether we can easily get access to some chonky Windows runners, but it really sucks that compiling Android on Apple Silicon doesn't work...

build/nuke/Build.Support.cs Outdated Show resolved Hide resolved
@Perksey
Copy link
Member Author

Perksey commented Oct 9, 2023

Ready for review.

@Perksey Perksey marked this pull request as ready for review October 9, 2023 22:01
@Perksey Perksey requested review from HurricanKai and a team as code owners October 9, 2023 22:01
Copy link
Contributor

@Beyley Beyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id like if we still ran the Test step at least on windows as well, but that can be done in a later PR at some point, but im happy with this change

@Perksey Perksey merged commit 9014e3b into main Oct 10, 2023
4 checks passed
@Perksey Perksey deleted the hotfix/apple-silicon-xlarge-runner branch October 10, 2023 00:53
Perksey added a commit that referenced this pull request Nov 20, 2023
* Evaluate Apple Silicon for CI

* Let's see what happens if we don't install old .NET versions

* sus error message on .NET 6

* BinaryFormatter 🤮🤮🤮

* Work around some deficiencies in the RC1 SDK (dotnet/sdk#35811)

* oops

* github.dev find+replace does not work

* Maths unit tests are now .NET 8

* Vulkan unit tests are now .NET 8

* Ok let's just disable tests for now

* Don't forget the public API!

* Attempt to fix android, as well as cache to make faster maybe

* Install Android platforms

* Reenable .NET 6?

* Install workloads for .NET 6 and .NET 8

* Comical hack

* ANNIHILATE .NET 8

* Install Android 31

* Maybe the tests are fine on .NET 6?

* they were not fine

* Forgo Apple Silicon for now

* Apparently caching is slower than JUST DOING IT

* Fix a very sus unit test failure

* Just testing something...

* Update build.yml

* attempt 2

* Tinker with Apple Silicon again

* Detailed verbosity, will probably regret this

* Update .NET 6

* Update build/nuke/Build.Support.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants