Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's new for preview 8 #2584

Merged
merged 5 commits into from
Aug 25, 2020
Merged

What's new for preview 8 #2584

merged 5 commits into from
Aug 25, 2020

Conversation

ajcvickers
Copy link
Member

No description provided.

@ajcvickers ajcvickers requested a review from a team August 23, 2020 21:40
@ajcvickers
Copy link
Member Author

@dotnet/efteam Should we include many-to-many here? I'm somewhat reluctant because there are a lot of additional tweaks/fixes that have gone in after we branched.

ajcvickers
ajcvickers commented Aug 23, 2020
View reviewed changes
entity-framework/core/what-is-new/ef-core-5.0/whatsnew.md Outdated

Documentation is tracked by issue [#2583](https://github.com/dotnet/EntityFramework.Docs/issues/2583).

### Flexible type/function mapping
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndriySvyryd @smitpatel Could one or both of you write either one combined or multiple different sections for the issues listed below? I'm not sure quite how to approach explaining this to people.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/efcore#21415 Can be ignored, this is very low-level

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 23, 2020 •
edited

Should we include many-to-many here?

Anyone following the issue already knows that some of it is there. I think that's enough exposure for now

@ajcvickers
Copy link
Member Author

ajcvickers commented Aug 24, 2020 •
edited

@dotnet/efteam:

  • Updated TPT to include the constraints
  • Added TVF mapping (/cc @pmiddleton - I started from what you wrote--it was very helpful, thanks!)
  • Added some words on query roots

@ajcvickers
Copy link
Member Author

@JeremyLikness I think this has everything in it now.

@ajcvickers
Copy link
Member Author

@dotnet/efteam Can I get approval on this so we can push to live for the release today.

@ajcvickers ajcvickers merged commit e8b3ec4 into master Aug 25, 2020
@ajcvickers ajcvickers mentioned this pull request Aug 27, 2020
Closed
@smitpatel smitpatel deleted the WhatsOld0822 branch September 2, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel left review comments

@pmiddleton pmiddleton pmiddleton left review comments

@bricelam bricelam bricelam approved these changes

@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ajcvickers @AndriySvyryd @bricelam @smitpatel @pmiddleton