Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compatibility with default scrape_configs #112

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

Adding compatibility with default scrape_configs
@0xbilko 0xbilko requested a review from dotdc as a code owner June 13, 2024 14:44
@dotdc
Copy link
Owner

dotdc commented Jun 20, 2024

Hi @beliys,

Do you have kubernetes-apiservers as a value in the job label?
Could you share more information on your setup?

If it's the case, I would rather create a job variable like it was the case before.
Let me know if you need help.

@0xbilko
Copy link
Contributor Author

0xbilko commented Jun 22, 2024

Hi @dotdc,
That's right, kubernetes-apiservers is the default value if you don't install it through kube-prometheus-stack or victoria-metrics-k8s-stack. And if you install this chart https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus or this https://github.com/VictoriaMetrics/helm-charts/tree/master/charts/victoria-metrics-agent, then you have job=kubernetes-apiservers. Of course, I can override all the rules in the default scrape_configs, but if this PR is not suitable, then it's easier for me to just fork this dashboard. But if you accept this PR, it will allow to use your dashboard in all standard cases, not just when using kube-prometheus-stack or victoria-metrics-k8s-stack.

@dotdc dotdc merged commit 62b540a into dotdc:master Jun 22, 2024
1 check passed
@dotdc
Copy link
Owner

dotdc commented Jun 22, 2024

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Jun 22, 2024
@dotdc
Copy link
Owner

dotdc commented Jun 22, 2024

Sure, will probably create a job variable at some point.
Thank you for your contribution!

dotdc added a commit that referenced this pull request Jun 22, 2024
sdlarsen pushed a commit to digital-science/grafana-dashboards-kubernetes that referenced this pull request Jul 10, 2024
sdlarsen pushed a commit to digital-science/grafana-dashboards-kubernetes that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants