Update power management page #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhinakg
changed the title
PMheart
reviewed
Jun 21, 2022
PMheart
reviewed
Jun 21, 2022
PMheart
reviewed
Jun 21, 2022
PMheart
reviewed
Jun 21, 2022
|
I would also recommend putting CPUFriend instructions (https://github.com/acidanthera/CPUFriend/blob/master/Instructions.md) somewhere. |
PMheart
reviewed
Jul 25, 2022
PMheart
reviewed
Jul 25, 2022
PMheart
reviewed
Jul 25, 2022
PMheart
reviewed
Jul 25, 2022
1Revenger1
previously requested changes
Jul 27, 2022
Co-authored-by: Avery Black <[email protected]>
Co-authored-by: Avery Black <[email protected]>
Co-authored-by: Avery Black <[email protected]>
PMheart
reviewed
Jul 31, 2022
PMheart
reviewed
Jul 31, 2022
PMheart
reviewed
Jul 31, 2022
PMheart
reviewed
Jul 31, 2022
PMheart
reviewed
Aug 3, 2022
PMheart
reviewed
Aug 8, 2022
| @@ -116,7 +144,7 @@ This final entry is to help macOS out what kind of overall performance you'd lik | |||
| Once you're finished, you'll be provided with a CPUFriendDataProvider.kext and ssdt_data.aml. Which you choose is your preference but I recommend the kext variant to avoid any headaches with data injection into Windows and Linux. | |||
|
|
|||
| * **Note**: Load order does not matter with the CPUFriendDataProvider as it's just a plist-only kext | |||
| * **Note 2**: Wake issues resulting from CPUFriend is likely due to incorrect frequency vectors, every system is unique so you'll need to play around until you get a stable config. Kernel panics will have `Sleep Wake failure in efi`. | |||
| * **Note 2**: Wake issues resulting from CPUFriend are likely due to incorrect power management data. Every system is unique so you'll need to play around until you get a stable config. Kernel panics will have `Sleep Wake failure in efi`. Reusing power management data from old macOS versions can also cause issues, so recreate your data provider if you update macOS. | |||
| * **Note 3**: If you do choose to use ssdt_data.aml, note that SSDT-PLUG is no longer needed. However the setup for this SSDT is broken on HEDT platforms like X99 and X299, so we highly recommend SSDT-PLUG with CPUFriendDataProvider.kext instead. | |||
There was a problem hiding this comment.
Just an idea following Note 2 - maybe we could mention creating CPUFriendDataProvider_OSVersion.kext and then set Min/MaxKernel such that specific set of power management data is injected for different versions of macOS.
|
The rest looks good to me. I may compose a separate PR if I could help with anything afterwards. |
|
Looks good to me now. I will add an option to CPUFriend’s ResourceConverter creating data provider kexts with version later. |
dhinakg
dismissed
1Revenger1’s stale review
communicated on another platform, looks good
1Revenger1
approved these changes
Aug 8, 2022
abenraj
reviewed
Aug 9, 2022
|
|
||
| ::: tip | ||
|
|
||
| SSDT-PLUG is not required on 12.4 and up. |
There was a problem hiding this comment.
plugin-type=1 check was dropped on macOS 12.3b1+
There was a problem hiding this comment.
Right. Thanks. Please file a PR for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes dortania/bugtracker#267