Fix: Wait until dora daemon is connected to coordinator on dora up
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might take a short time until the daemon is connected to the coordinator after start-up. This could lead to issues when using `dora up` in a script because a subsequent `dora start` command might fail when the daemon is not connected at that point. This commit fixes this issue by waiting until the coordinator confirms that a daemon is connected before returning from `dora up`.
haixuanTao
approved these changes
May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might take a short time until the daemon is connected to the coordinator after start-up. This could lead to issues when using
dora upin a script because a subsequentdora startcommand might fail when the daemon is not connected at that point.This commit fixes this issue by waiting until the coordinator confirms that a daemon is connected before returning from
dora up.