Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown-mode: header-face size & color #742

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

stradicat
Copy link

Hierarchical size & color modifications, so that larger, structured markdown files become a bit easier to read, keeping the palette simple.


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My changes are visual; I've included before and after screenshots.
  • Gruvbox

    • Before:
      Captura de Pantalla 2022-08-02 a la(s) 12 47 59

    • After:
      Captura de Pantalla 2022-08-02 a la(s) 12 48 23

  • Gruvbox Light

    • Before:
      Captura de Pantalla 2022-08-02 a la(s) 12 46 33

    • After:
      Captura de Pantalla 2022-08-02 a la(s) 12 47 04

  • Doom-One

    • Before:
      Captura de Pantalla 2022-08-02 a la(s) 12 49 24

    • After:
      Captura de Pantalla 2022-08-02 a la(s) 12 49 48

  • Doom-One Light

    • Before:
      Captura de Pantalla 2022-08-02 a la(s) 12 50 33

    • After:
      Captura de Pantalla 2022-08-02 a la(s) 12 50 51

Hierarchical size & color modifications, so that larger, structured `markdown`files become a bit easier to read.
Hierarchical size & color modifications, so that larger, structured `markdown` files become a bit easier to read.
Hierarchical size & color modifications, so that larger, structured `markdown` files become a bit easier to read.
Hierarchical size & color modifications, so that larger, structured `markdown` files become a bit easier to read.
@hlissner hlissner marked this pull request as draft August 2, 2022 23:03
@hlissner hlissner added is:tweak Code changes that affects user-facing behavior theme:one theme:one-light theme:gruvbox theme:gruvbox-light is:faces Pertains to extending/improving support for Emacs or plugin faces and removed is:tweak Code changes that affects user-facing behavior labels Aug 2, 2022
@hlissner hlissner added this to the Backlog milestone Aug 2, 2022
@hlissner
Copy link
Member

hlissner commented Aug 2, 2022

I've temporarily converted this to a draft because this PR needs some work. Specifically, I have intentionally avoided adjusting :height's on org and markdown headings. If we're going to add it, I want it standardized behind a variable that's disabled by default, and have it available to all themes.

That said, this is not a request for you to change the PR. The decision rests on some other work that I have brewing for this project. I will get back to this soon.

@stradicat
Copy link
Author

Hi @hlissner!

Thanks for considering my PR; no worries, standardization is something I'd do myself for a project like this, with the least amount of friction possible.

Cheers!

@spacefrogg
Copy link
Contributor

For completeness, the meltbus theme has such a variable, doom-meltbus-uniform-font-size, but it is disabled by default (because I like having larger headers, and there was no such discussion when I created it). This being said, I completely support this (also that font heights are uniform by default). So, also take this as a naming suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:faces Pertains to extending/improving support for Emacs or plugin faces theme:gruvbox theme:gruvbox-light theme:one theme:one-light
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants