Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update-readme #75

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Feature/update-readme #75

merged 6 commits into from
Jun 16, 2022

Conversation

dongminlee94
Copy link
Owner

@dongminlee94 dongminlee94 commented Jun 12, 2022

PR Description

  • Update README
  • Change directory structure of meta_sl

Test

Related Issues

Anything Else? (Optional) Optional section (e.g., code usage, experimental results, TODO)

//: # (If there are any other things (e.g., code usage, experimental results, TODO), please explain them.)

@github-actions github-actions bot added the size/M medium size label Jun 12, 2022
@github-actions github-actions bot requested a review from Clyde21c June 12, 2022 13:49
@github-actions github-actions bot added the feature New feature label Jun 12, 2022
@Clyde21c
Copy link
Collaborator

@dongminlee94 README 변경사항 확인했습니다. approve하면될까요?

@dongminlee94
Copy link
Owner Author

@Clyde21c 아뇨! 아직 작업중입니다! 제가 따로 말씀드릴게요 ㅎㅎ

@github-actions github-actions bot added size/L big size and removed size/M medium size labels Jun 16, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 16, 2022

This pull request fixes 2 alerts when merging 482e7e8 into 77fab64 - view on LGTM.com

fixed alerts:

  • 2 for Variable defined multiple times

Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great README

@dongminlee94 dongminlee94 merged commit 69cfdd6 into main Jun 16, 2022
@dongminlee94 dongminlee94 deleted the feature/update-readme branch June 16, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature size/L big size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants