Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance/apply-curt-park-comments #108

Merged
merged 2 commits into from
Oct 6, 2022
Merged

enhance/apply-curt-park-comments #108

merged 2 commits into from
Oct 6, 2022

Conversation

dongminlee94
Copy link
Owner

@dongminlee94 dongminlee94 commented Oct 6, 2022 •
edited
Loading

PR Description

  • 진우님 issue 2개 해결

Test

$ make init-dev

Related Issues

#106
#107

@github-actions github-actions bot added the size/XL too big size label Oct 6, 2022
@github-actions github-actions bot added the enh Enhancement label Oct 6, 2022
Clyde21c
Clyde21c approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dongminlee94 dongminlee94 merged commit 9166337 into main Oct 6, 2022
@dongminlee94 dongminlee94 deleted the enhance/apply-curt-park-comments branch October 6, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clyde21c Clyde21c Clyde21c approved these changes

Assignees

@dongminlee94 dongminlee94

Labels
enh Enhancement size/XL too big size
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dongminlee94 @Clyde21c