-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release: v1.0.0-alpha.13 #2479
Conversation
WalkthroughOhayo, sensei! This pull request features an update to the version number in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -52,7 +52,7 @@ edition = "2021" | |||
license = "Apache-2.0" | |||
license-file = "LICENSE" | |||
repository = "https://github.com/dojoengine/dojo/" | |||
version = "1.0.0-alpha.12" | |||
version = "1.0.0-alpha.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Ohayo, sensei!
Great job on updating the version to "1.0.0-alpha.13"! 🎉 However, I noticed that CHANGELOG.md
is missing from the repository. To ensure we keep our updates transparent and well-documented, please consider adding a CHANGELOG.md
detailing the changes in this release.
🔗 Analysis chain
Ohayo, version update looks good, sensei!
The bump from "1.0.0-alpha.12" to "1.0.0-alpha.13" is spot on for this release prep. It's following our semantic versioning ways like a true coding ninja!
Let's make sure this version change is consistent across the dojo, sensei:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the version is consistently updated across the project
# Test 1: Verify the version in Cargo.toml
echo "Checking Cargo.toml:"
grep 'version =' Cargo.toml
# Test 2: Look for any other occurrences of the old version
echo "Checking for any remaining occurrences of the old version:"
rg '1\.0\.0-alpha\.12' --type-not toml
# Test 3: Verify changelog is updated (if exists)
echo "Checking CHANGELOG.md (if it exists):"
if [ -f CHANGELOG.md ]; then
rg '1\.0\.0-alpha\.13' CHANGELOG.md
else
echo "CHANGELOG.md not found. Consider adding one for tracking changes, sensei!"
fi
Length of output: 2607
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
=======================================
Coverage 68.64% 68.64%
=======================================
Files 372 372
Lines 48441 48441
=======================================
Hits 33251 33251
Misses 15190 15190 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit