Fix rendering for value attribute on option tag (#296)

dojo · Feb 16, 2019 · c5cc54b · c5cc54b
1 parent ddcbf3f
commit c5cc54b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/dtl/dom.js b/dtl/dom.js
@@ -223,9 +223,6 @@ define([
  value = node.className || value;
  }else if(key == "for"){
  value = node.htmlFor || value;
- }else if(key == "value" && node.value == node.innerHTML){
- // Sometimes .value is set the same as the contents of the item (button)
- continue;
  }else if(node.getAttribute){
  value = node.getAttribute(key, 2) || value;
  if(key == "href" || key == "src"){

diff --git a/dtl/tests/dom/tag.js b/dtl/tests/dom/tag.js
@@ -329,5 +329,25 @@ doh.register("dojox.dtl.dom.tag",
  const htmlResult = template.render(context).getParent().outerHTML;
  t.is('<div attr=""></div>', htmlResult);
  },
+ function test_option_tag_with_same_value_attribute_and_innerHTML(t){
+ var dd = dojox.dtl;
+
+ const html =
+ '<div>'
+ + '<select>'
+ + '<option value="{{fruit}}">{{fruit}}</option>'
+ + '</select>'
+ + '</div>';
+ var template = new dd.DomTemplate(html);
+ var context = new dd.Context({ fruit : "Fruit" });
+ const htmlResult = template.render(context).getParent().outerHTML;
+ const htmlExpected =
+ '<div>'
+ + '<select>'
+ + '<option value="Fruit">Fruit</option>'
+ + '</select>'
+ + '</div>';
+ t.is(htmlExpected, htmlResult);
+ },
  ]
 );