Rework D3D9 float emulation - as an option #2359
Merged
+197
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
requested review from
Joshua-Ashton and
doitsujin
and removed request for
Joshua-Ashton
DadSchoorse
reviewed
Nov 12, 2021
DadSchoorse
suggested changes
Nov 12, 2021
K0bin
force-pushed
the
d3d9-float-memes
branch
from
5812b38
to
7d8b9de
Compare
K0bin
force-pushed
the
d3d9-float-memes
branch
from
7d8b9de
to
0900fd1
Compare
... that are known to be broken without it.
K0bin
force-pushed
the
d3d9-float-memes
branch
from
0900fd1
to
03c9d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically #2294 except that it's an option only enabled for specific games. (the ones in #2195)
The option
d3d9.floatEmulationgets a third option besidesTrueandFalsecalledStrictwhich enables the more accurate implementation. Once Mesa has landed an optimization for this, we can just make it automatically pickStrict.