Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to French-Canadian Translations #3441

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

daank-c
Copy link
Contributor

@daank-c daank-c commented Feb 22, 2024

This is a fairly large update to the French-Canadian translation file bitcoin_fr_CA.ts, as it was almost bare when I started a couple days ago. I filled in about 75% of the translations available, but left the other 25% for another time.

For the most part, the changes I've made here were grabbed from a version of bitcoin_fr.ts prior to #3195 . I did make some minor adjustments to wording and added some missing punctuation, but nothing too major.

@patricklodder patricklodder requested a review from a team February 22, 2024 11:27
@patricklodder patricklodder added this to the 1.14.7 milestone Feb 22, 2024
@patricklodder patricklodder mentioned this pull request Feb 22, 2024
43 tasks
@patricklodder
Copy link
Member

Looks good technically 👍.

I've added "help wanted": it would be great if a native speaker could review.

@daank-c
Copy link
Contributor Author

daank-c commented Feb 25, 2024

The changes in this latest commit improved translations, were made after a recommendation from a native speaker.

The conversation took place on X. We're still hashing out some technical interpretations in that same conversation.

@patricklodder
Copy link
Member

The conversation took place on X. We're still hashing out some technical interpretations in that same conversation.

Noting @John-Inubook as reviewer.

@daank-c
Copy link
Contributor Author

daank-c commented Feb 25, 2024

John has finished looking it over and I've made all the changes he suggested. Here's the end of that conversation, for the record. That's the last commit, if everything looks good to you. @patricklodder

@patricklodder
Copy link
Member

Could really use a squash. Let me know if you need help or have me do it for you.

@John-Inubook
Copy link

I'm French Canadian, I've read the work made by Daansky and I shared with him on X the different changes that needed to be done. Glad I could be of any help.

- Initial update to bitcoin_fr_CA.ts
- Small fixes, including typos and minor syntax errors
- Improved translation to better reflect common usage in French-Canadian context
- Minor improvements to translation, including fixing a typo and updating wording
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - code review ok

Language validation by @John-Inubook

@patricklodder patricklodder merged commit 09ef9f1 into dogecoin:1.14.7-dev Feb 27, 2024
14 checks passed
patricklodder added a commit to patricklodder/dogecoin that referenced this pull request Feb 27, 2024
@daank-c daank-c deleted the translate-fr_CA branch March 1, 2024 16:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants