Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented additional route for checking usernames #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

implemented additional route for checking usernames #6

wants to merge 4 commits into from

Conversation

dmitryt
Copy link
Contributor

@dmitryt dmitryt commented May 25, 2018

Closes #3

denysdovhan
denysdovhan requested changes May 25, 2018
View reviewed changes
Copy link
Member

@denysdovhan denysdovhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update README

routes/auth.js Outdated
@@ -67,4 +68,22 @@ authRouter.get('/logout', (req, res, next) => {
});
});

authRouter.get('/check-user', (req, res, next) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using req.params or smth like that. we already have a middleware for parsing params.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dmitryt
Copy link
Contributor Author

dmitryt commented May 28, 2018

Fixed

@dmitryt
Copy link
Contributor Author

dmitryt commented Jun 2, 2018

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitryt @denysdovhan