Add NotifyPropertyChanged, PropertyChangedListener

[olvlvl]

Fix doctrine/common#855

[Majkl578]

Hi,
thanks for working on this! I restarted the crashed build, can you please see & address the CS issues? Thanks.

[Majkl578]

Also please bump the conflict here:

persistence/composer.json

Line 36 in b8b8b93

"doctrine/common": "<2.9@dev"

to <2.10@dev.

[olvlvl]

@Majkl578 This time, I ran ./vendor/bin/phpcs before committing :)

[Majkl578]

Nice, thanks. 👍
Do you also want to prepare the reverse operation in doctrine/common (removal + doctrine/persistence bump)? 😎

[Ocramius]

Mostly documentation wording improvements needed. These classes are tricky to describe, so we should be careful about what we're writing in here.

[Ocramius]

Please use {@see MyClass}

[Ocramius]

The cyclical dependency of these classes is a bit hard to grasp: can we add another sentence or two that don't involve explaining this with NotifyPropertyChanged in mind?

[Ocramius]

"Collect information about a property change"

[Majkl578]

@Ocramius I'd personally prefer doing such changes in separate PR, leaving this only a move stuff from X to Y.

[olvlvl]

I second that :)

[Ocramius]

If it's got to be committed, and it counts as an addition, let's use the chance to improve that.

We all know very well that otherwise it just lands in the endless wastelands of "I wish we did also X".

[alcaeus]

I agree with @Majkl578 here. Wording improvements are one thing, but this feature needs comprehensive documentation anyways. This can be copied from the "Change tracking policies" sections of the ORM and MongoDB ODM docs and adapted to be generic, but this functionality isn't something we can easily explain in the docblock of an interface. As such, I'm 👍 merging it as is.

[olvlvl]

I updated the dock-block with @alcaeus suggestion.

[Majkl578]

LGTM, changes suggested by @Ocramius were addressed, as for the documentation itself let's do it in separate PR (extracting it from ORM/ODM docs).