Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Skip type comparison if disableTypeComments is true #6423

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

berkut1
Copy link
Contributor

@berkut1 berkut1 commented Jun 5, 2024

Q A
Type bug
Fixed issues #6422

Summary

In the #6150, a check was missed when we were validating the database schema.

@greg0ire
Copy link
Member

greg0ire commented Jun 5, 2024

Can you please add a unit test?

@greg0ire greg0ire added the Bug label Jun 5, 2024
@berkut1
Copy link
Contributor Author

berkut1 commented Jun 5, 2024

How do I test this? I tried to understand it by looking at the previous pull request #6150, but I didn't find any tests there. I guess I need to create a Comparator object with a Platform, but in AbstractComparatorTestCase Class, no object is created in any test except setUp().
Do I really need to create it in my test function and pass disableTypeComments? It seems strange to me considering all the other tests.

Or should I write a test in AbstractPlatformTestCase?

@berkut1
Copy link
Contributor Author

berkut1 commented Jun 6, 2024

Do you think such a test would be suitable? After reviewing AbstractPlatformTestCase, it seems like the most appropriate place for it.

greg0ire
greg0ire previously approved these changes Jun 6, 2024
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The place seems appropriate. I don't think you need to create a Comparator though.

@greg0ire greg0ire dismissed their stale review June 6, 2024 07:35

Didn't mean to approve yet, only comment for now, but after the suggested change it should be good

@berkut1
Copy link
Contributor Author

berkut1 commented Jun 6, 2024

Thanks, I'm fine with those changes.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namings are weird to read without the context of the issues #6422 and #6257 😅

@greg0ire greg0ire added this to the 3.8.5 milestone Jun 7, 2024
@greg0ire greg0ire merged commit 537e6b3 into doctrine:3.8.x Jun 7, 2024
92 checks passed
@greg0ire
Copy link
Member

greg0ire commented Jun 7, 2024

Thanks @berkut1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants