Fix example for QB delete and update in doc block #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$alias parameter in update() and delete() was removed in version 4 but the example still use the second parameter. Example was updated in this PR
greg0ire
approved these changes
May 14, 2024
SenseException
approved these changes
May 14, 2024
derrabus
pushed a commit
that referenced
this pull request
Jul 16, 2024
<!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | bug/improvement | Fixed issues | Incorrect & inconsistent QueryBuilder documentation for aliases in update/delete #### Summary In #6394 the documentation was partially updated to remove aliases for the documentation for the update method, as the separate parameter for it was removed in the upgrade from 3.x to 4.x. Inline aliasing is still possible, and I suspect this was the reason the extra parameter was removed. ( `->update('users alias1', 'alias2')`)? This PR readds the alias to the documentation for the occurences in the linked PR, and also updates the other occurences in docblocks + the online documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$alias parameter in update() and delete() was removed in version 4 but the example still use the second parameter. Example was updated in this PR