Use 3.8.x as a target for dependabot version updates #6384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Dependabot checks the default branch, and raises pull requests against it. Since we are using a merge-up workflow, we should tell it to target 3.8.x. This is not great because it will mean we will have to maintain that setting for as long as we maintain the old patch branch, but I do not think there is a better solution.
greg0ire
commented
May 5, 2024
| @@ -6,3 +6,4 @@ updates: | |||
| interval: "weekly" | |||
| labels: | |||
| - "CI" | |||
| target-branch: "3.8.x" | |||
There was a problem hiding this comment.
It's unclear to me if Dependabot will start monitoring 3.8.x rightaway or after we merge this up into the default branch. Once it is merged up into the default branch, I think it will take other modifications to the file on that branch rightaway, so I think this is still the right move.
derrabus
approved these changes
May 5, 2024
derrabus
added a commit
that referenced
this pull request
May 16, 2024
* 4.1.x: Fix example for QB delete and update in doc block Bump doctrine/.github from 5.0.0 to 5.0.1 (#6391) PHPStan 1.10.67, PHPUnit 9.6.19, PHPCS 3.9.2 (#6387) Fix "Plugin 'mysql_native_password' is not loaded" (#6388) Run tests against MySQL 8.4 (#6386) Use 3.8.x as a target for dependabot version updates (#6384) Setup dependabot Fix SQLiteSchemaManagerTest case Switch to substr implementation fix merge Bump workflow actions Fix SQL Server "extended property" SQL generation (#6353) Fix DB name passing in SqliteSchemaManager::listTableForeignKeys() (#6338) Fix SQLite temp table name must not contain dot (#6315) Provide CODECOV_TOKEN Upgrade to codecov/codecov-action v4 Set fail_ci_if_error flag to true Specify the minor version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Dependabot checks the default branch, and raises pull requests against it. Since we are using a merge-up workflow, we should tell it to target 3.8.x. This is not great because it will mean we will have to maintain that setting for as long as we maintain the old patch branch, but I do not think there is a better solution.
Documentation: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#target-branch