Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AbstractPlatform::getName() #4763

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Remove AbstractPlatform::getName() #4763

merged 2 commits into from
Aug 27, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 27, 2021

Q A
Type improvement
BC Break yes

See #4755.

@morozov morozov added this to the 4.0.0 milestone Aug 27, 2021
@morozov morozov requested a review from greg0ire August 27, 2021 18:36
greg0ire
greg0ire approved these changes Aug 27, 2021
View reviewed changes
tests/Platforms/DB2PlatformTest.php
public function testHasCorrectPlatformName(): void
{
self::assertEquals('db2', $this->platform->getName());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know something is up when you end up writing such tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have been one of us who aim at higher code coverage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily they did not do it for all platforms so… +0.41% 🎉

@morozov morozov merged commit 8a9141e into doctrine:4.0.x Aug 27, 2021
@morozov morozov deleted the remove-platform-get-name branch August 27, 2021 19:29
@jderusse jderusse mentioned this pull request Oct 3, 2021
Merged
@morozov morozov mentioned this pull request Oct 11, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Platforms PostgreSQL SQL Server
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @greg0ire