[SQL Anywhere] Fix bound parameter references in PHP 7 #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deeky666 any way to test this, or do integration tests already fail? |
|
@Ocramius integration tests already fail big time. The other failures are unrelated and need to be fixed separately. Before: https://pastebin.com/CS0dGa3i |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The SQL Anywhere driver suffers the same problem that
oci8did with PHP 7 (See: ae314b1)Binding multiple parameters in a prepared statement does not work as PHP does not manage the references itself. We have to manage the references to bound parameters ourself, otherwise only the first bound parameter is used and overwritten subsequently.
The tests are revealing the issue already.