configure default builder export when no build.platforms defined #9862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Lours <[email protected]>
nicksieger
approved these changes
Sep 20, 2022
milas
approved these changes
Sep 20, 2022
| @@ -81,6 +81,12 @@ func (s *composeService) build(ctx context.Context, project *types.Project, opti | |||
| Attrs: map[string]string{"ref": image}, | |||
| }) | |||
| } | |||
| buildOptions.Exports = []bclient.ExportEntry{{ | |||
There was a problem hiding this comment.
Nit: it'd be a bit clearer if it was something like
if len(buildOptions.Platforms) == 0 {
// docker load
} else {
// image out
}Mostly to make it clear that they're mutually exclusive / an intentional override.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Defined a docker builder exporter by default to make the image available in the engine context
Related issue
fixes #9856
(not mandatory) A picture of a cute animal, if possible in relation with what you did
