Use logrus instead of direct output to stderr #11996
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
Jul 23, 2024
pkg/compose/build_classic.go
Outdated
| @@ -180,7 +182,7 @@ func (s *composeService) doBuildClassic(ctx context.Context, project *types.Proj | |||
| aux := func(msg jsonmessage.JSONMessage) { | |||
| var result dockertypes.BuildResult | |||
| if err := json.Unmarshal(*msg.Aux, &result); err != nil { | |||
| fmt.Fprintf(s.stderr(), "Failed to parse aux message: %s", err) | |||
| logrus.Warnf("Failed to parse aux message: %s", err) | |||
There was a problem hiding this comment.
Thanks, adjusted it.
Signed-off-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
There are two warnings on stderr that
--progress json(#11478) still emits as plain text. This is because they are printed there directly, without using logrus or the events framework.This PR changes these places to use
logrus.Warnf(...)instead offmt.Fprintf(s.stderr(), ...).Related issue
Ref: #11478 (not an issue, but a PR)