driver: set network.host entitlement by default for container drivers #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be a potentially breaking change (from security perspective), and has to be documented? |
AkihiroSuda
reviewed
Feb 22, 2024
builder/builder.go
Outdated
|
|
||
| if !hasNetworkHostEntitlement { | ||
| // always set network.host entitlement as container network is | ||
| // isolated for docker-container and kubernetes drivers |
There was a problem hiding this comment.
In the comment could you explain the purpose of setting the entitlement by default?
It is not. The default networking for build step containers if builder was in container was already host (meaning host inside the container, not host of machine) and will remain like this in v0.13. This was without setting any |
tonistiigi
reviewed
Feb 22, 2024
crazy-max
force-pushed
the
container-driver-host-entl
branch
from
ae3436e
to
48ab88d
Compare
crazy-max
force-pushed
the
container-driver-host-entl
branch
3 times, most recently
from
2d6ae5c
to
4d88ca6
Compare
tonistiigi
approved these changes
Feb 23, 2024
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
container-driver-host-entl
branch
from
4d88ca6
to
e008b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2255