Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade actions/checkout to v4 #1041

Conversation

k-yamasaki-zakisan
Copy link
Contributor

@k-yamasaki-zakisan k-yamasaki-zakisan commented Jan 26, 2024

Description:
Thanks for your work. The actions/checkout has been released to v4, I have updated README to use it.

crazy-max

This comment was marked as outdated.

@crazy-max
Copy link
Member

Thank you for contributing! It appears your commit message is missing a DCO sign-off, causing the DCO check to fail: https://github.com/docker/build-push-action/pull/1041/checks?check_run_id=20888520981

We require all commit messages to have a Signed-off-by line with your name and e-mail, which looks something like:

Signed-off-by: YourFirsName YourLastName <[email protected]>

There is no need to open a new pull request, but to fix this (and make CI pass), you need to amend the commit(s) in this pull request, and "force push" the amended commit.

Unfortunately, it's not possible to do so through GitHub's web UI, so this needs to be done through the git commandline.

You can find some instructions in the output of the DCO check (which can be found in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

  1. Set your name and e-mail in git's configuration:

    git config --global user.name "YourFirstName YourLastName"
    git config --global user.email "[email protected]"
    

    (Make sure to use your real name (not your GitHub username/handle) and e-mail)

  2. Clone your fork locally

  3. Check out the branch associated with this pull request

  4. Sign-off and amend the existing commit(s)

    git commit --amend --no-edit --signoff
    

    If your pull request contains multiple commits, either squash the commits (if needed) or sign-off each individual commit.

  5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!

Signed-off-by: Kazuyoshi Yamasaki <[email protected]>
@k-yamasaki-zakisan k-yamasaki-zakisan force-pushed the feature/upgrate-readme-to-actions/checkout@v4 branch from dba94b9 to 2b28f2a Compare January 26, 2024 08:22
@k-yamasaki-zakisan
Copy link
Contributor Author

Thanks for the manual. With your help, I was able to configure the DCO. I hope this setup works out well...
if my configuration is wrong, let me know.👋

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@crazy-max crazy-max merged commit 94d76d3 into docker:master Jan 26, 2024
51 checks passed
@k-yamasaki-zakisan k-yamasaki-zakisan deleted the feature/upgrate-readme-to-actions/checkout@v4 branch January 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants