Fix test for different API behaviour. #642
Conversation
KostyaSha
force-pushed
the
fixExecStartTest
branch
from
ec32b06
to
a79f5d8
Compare
| assertEquals(stdout.toString(), ""); | ||
|
|
||
| if (getVersion(dockerClient).isGreaterOrEqual(VERSION_1_23)) { |
There was a problem hiding this comment.
@tjlee do you have the same changes?
There was a problem hiding this comment.
@KostyaSha Actually it was all around test code base. During refactoring i touch this but without clear understanding. But if the same behavior changes withing API versions it can be used but the best way to create parametrized test with API version as param (tags if fine too, like with cicleci)
There was a problem hiding this comment.
That one of the ways, but i decided to make conditionals in tests. Would also help understand for end users tests as examples.
With groups/tags you can only exclude Test from run, here it only checks behaviour.
|
For such a way (show behavior) it is seems to be the best way |
|
Test looks working, will merge, if it fail again - will fix again. |
This change is