This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Bump version to v1.2.4-rc2 #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #### API | ||
|
|
||
| - Code refactoring | ||
| - Additional error handling | ||
| - Update minimum Docker Engine version supported by Swarm to 1.8 | ||
| - New client interface in Swarm, to differentiate from Swarm mode in Docker 1.12 |
There was a problem hiding this comment.
Maybe better to reorder them by significance. The last item has bigger impact.
|
LGTM |
Signed-off-by: Nishant Totla <[email protected]>
ff204b6
to
5356356
Compare
|
@dongluochen addressed your comments. |
|
LGTM |
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
Bump version to v1.2.4-rc2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dongluochen @abronan
Signed-off-by: Nishant Totla [email protected]