Fixed bug that gives pressure=NaN when a species has phi=0 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a solvent or polymer is included in the param file but has phi=0, the calculated pressure of the system is erroneously reported as NaN because the software is calculating 0*(-inf) as the contribution of the nonexistent species to the pressure. This pull request will fix this bug for fd1d, pspc, and pspg by only calculating the free energy contributions of species for which phi>1E-08. I ran a quick test and it compiles and runs correctly.
This is the same bug that was addressed by my recent pull request in pscfpp, except in the Fortran code it is only the pressure that was reported as NaN, the free energy was being calculated correctly.