Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize file system path. #9463

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Normalize file system path. #9463

merged 4 commits into from
Aug 11, 2023

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Aug 10, 2023 •
edited
Loading

Close #9453 .

  • Normalize the path for the model.
  • Normalize the path for text input.

rhub log: https://builder.r-hub.io/status/xgboost_2.0.0.1.tar.gz-160da06d62034e7c905e78a24542dc2c .

@trivialfis trivialfis requested a review from hcho3 August 10, 2023 19:32
hcho3
hcho3 reviewed Aug 10, 2023
View reviewed changes
src/data/file_iterator.cc Outdated Show resolved Hide resolved
@trivialfis trivialfis added this to 2.0 In Progress in 2.0 Roadmap via automation Aug 11, 2023
@trivialfis trivialfis merged commit bb56183 into dmlc:master Aug 11, 2023
26 checks passed
2.0 Roadmap automation moved this from 2.0 In Progress to 2.0 Done Aug 11, 2023
@trivialfis trivialfis deleted the norm-path branch August 11, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
2.0 Roadmap
  
2.0 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R test fail on Windows with file reading.
2 participants
@trivialfis @hcho3