[CI] [jvm-packages] Build libxgboost4j.dylib on M1 MacOS with OpenMP support #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
added a commit
to hcho3/xgboost
that referenced
this pull request
Jun 19, 2024
hcho3
added a commit
that referenced
this pull request
Jun 19, 2024
|
@hcho3 Does this affect user binaries? Should I put it into the release news as a new feature or as maintenance? |
|
Yes, it affects user binaries. You should put this in the new feature, since now OpenMP is a requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CI pipeline builds
libxgboost4j.dylib(M1, arm64) with OpenMP turned off.We should enable it for M1 as well.