Skip to content
This repository has been archived by the owner on Feb 1, 2020. It is now read-only.

Expose clip to frontend mxnet #512

Merged
merged 4 commits into from
May 25, 2018
Merged

Expose clip to frontend mxnet #512

merged 4 commits into from
May 25, 2018

Conversation

ehsanmok
Copy link
Contributor

@ehsanmok
Copy link
Contributor Author

@tqchen you'd need to update mxnet to v1.2 where MobilenetV2 was added recently.

@tqchen
Copy link
Member

tqchen commented May 23, 2018

CI update is a bit brittle and we would consider doing it later, can you remove the mobilenet mxnet test for now? Just adding unittest of clip will do

@ehsanmok
Copy link
Contributor Author

@tqchen sure, but shall I keep the added get_gluon_output in test? as you know, pretrained models are all now in gluon.

@tqchen
Copy link
Member

tqchen commented May 24, 2018

sounds good

@ehsanmok
Copy link
Contributor Author

@tqchen ping

@tqchen tqchen merged commit 361a228 into dmlc:master May 25, 2018
@tqchen
Copy link
Member

tqchen commented May 25, 2018

Thanks, this is merged

@ehsanmok ehsanmok deleted the frontend-mxnet-clip branch May 26, 2018 00:01
abergeron pushed a commit to abergeron/nnvm that referenced this pull request May 31, 2018
larroy pushed a commit to larroy/nnvm that referenced this pull request Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants