-
Notifications
You must be signed in to change notification settings - Fork 538
Remove gluon.utils.download copy with verify_ssl support #193
Conversation
We will need to wait until we update the dependency with a nightly version that includes the update in download before we merge. |
Currently the updated |
It turns out the webserver is still not fixed. The issue is that it does not serve an intermediary certificate that is needed to establish the trust from the root CA to the websites certificate. Newer browsers include the intermediary certificate used, so no error is shown when accessing the file with Firefox. I have contacted the admin and asked to include the intermediary certificates. More info about the certificate issues can be found here https://www.ssllabs.com/ssltest/analyze.html?d=ie.technion.ac.il |
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 67.84% 67.84%
=======================================
Files 72 72
Lines 7109 7109
=======================================
Hits 4823 4823
Misses 2286 2286 Continue to review full report at Codecov.
|
The problematic server now servers a valid SSL certificate.
Job PR-193/16 is complete. |
@leezu it passed. Was the issue upstream fixed? |
No, I made use of the verify_ssl=False that was added to upstream mxnet. |
I haven't received a response from the webmaster. They seem unwilling to fix their server. |
Description
The problematic server now servers a valid SSL certificate. Also apache/mxnet#11546 will add the option upstream.
Checklist
Essentials
Changes
Comments