Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to mxnet-cu92mkl #578

Merged
merged 4 commits into from
Jan 18, 2019
Merged

switch to mxnet-cu92mkl #578

merged 4 commits into from
Jan 18, 2019

Conversation

ZhennanQin
Copy link
Contributor

No description provided.

@ZhennanQin
Copy link
Contributor Author

@zhreshold After some investigation, found that it's crashed in mxnet::op::BipartiteMatchingForwardmshadow::cpu. This op doesn't relate to mkl or mkldnn , but possibly has memory access bug exposed by mkl build. Do you know any risk for this op causing heap corruption? Thanks in advance.

@zhreshold
Copy link
Member

@ZhennanQin Can you try the latest nightly build of mkl cu92? Recently I just merged a PR fixing memory issue of BipartiteMatching OP

apache/mxnet#13727

@mli
Copy link
Member

mli commented Jan 17, 2019

Job PR-578-4 is done.
Docs are uploaded to http:https://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-578/4/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@ZhennanQin
Copy link
Contributor Author

@zhreshold After updating mxnet-cu92mkl to 1.5.0b20190115, CI can pass. Hurray! Thanks for pointing me the fix.

Do you have any other trouble for using mxnet mkl build?

@ZhennanQin ZhennanQin changed the title [WIP]switch to mxnet-cu92mkl switch to mxnet-cu92mkl Jan 17, 2019
@zhreshold
Copy link
Member

Looks good as long as CI has no complains. I will keep this one open for one day in case @hetong007 and @zhanghang1989 have extra prompt

@pengzhao-intel
Copy link

@zhreshold do you have the plan to cherry pick #13727 into release 1.4.x?

@zhreshold
Copy link
Member

@pengzhao-intel It was actually picked into 1.4.x by apache/mxnet#13900

@pengzhao-intel
Copy link

@wuxun-zhang please help test how much performance benefit we can gain after changing MKLDNN backend.
@zhreshold any recommended benchmark scripts for benchmarking or only use the CI tests?

@zhreshold
Copy link
Member

There's no existing benchmark scripts, but I think we can creating some using exsiting inference code.

@pengzhao-intel
Copy link

@zhreshold thanks a lot. Ping us when the code is ready.

@pengzhao-intel
Copy link

@zhreshold could you help merge the PR? thanks.

@zhreshold zhreshold merged commit 270fa57 into dmlc:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants