Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [DeviceType] Add support for MAIA #120

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

kyule7
Copy link
Contributor

@kyule7 kyule7 commented Mar 2, 2023

This PR extends DLDeviceType to support Microsoft MAIA devices.

@kyule7 kyule7 changed the title Add support for MsNpu [RFC] [DeviceType] Add support for MsNpu Mar 2, 2023
@tqchen
Copy link
Member

tqchen commented Mar 2, 2023

Thanks @kyule7 . Would like to get a bit more background on about this device type, is there any public available information that describes the proposed device?

@kyule7
Copy link
Contributor Author

kyule7 commented Mar 2, 2023

Thanks @kyule7 . Would like to get a bit more background on about this device type, is there any public available information that describes the proposed device?

I do not think there is any good public information about the device, so it is difficult to describe any background and details about it at the moment. Would extending DLDeviceType require any public knowledge about the device?

@tqchen
Copy link
Member

tqchen commented Mar 3, 2023

@kyule7 usually yes, since one goal of DLPack to be stable and widely used, so we would like to maintain a list of public available devices for that purpose. DLExtDevice would serve as a good middle ground for plug in less mature device requirements

@kyule7
Copy link
Contributor Author

kyule7 commented Mar 4, 2023

@kyule7 usually yes, since one goal of DLPack to be stable and widely used, so we would like to maintain a list of public available devices for that purpose. DLExtDevice would serve as a good middle ground for plug in less mature device requirements

I used DLExtDevice for experiment with a new device for functionality, and planned to extend dlpack first in order to extend the dependent frameworks for the device support. I will close this PR since I do not think any public information about the device is available currently.

@kyule7 kyule7 closed this Mar 4, 2023
@tqchen
Copy link
Member

tqchen commented Mar 4, 2023

thanks @kyule7 you are more than welcome to bring up followups once it is publicly available

@kyule7 kyule7 reopened this Nov 16, 2023
@kyule7
Copy link
Contributor Author

kyule7 commented Nov 16, 2023

Reopening it since Maia 100 is publicly announced.

@@ -116,6 +116,8 @@ typedef enum {
kDLWebGPU = 15,
/*! \brief Qualcomm Hexagon DSP */
kDLHexagon = 16,
/*! \brief Microsoft NPU */
kDLMsNpu = 17,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be kDLMSNPU? just to followup other convention for abbrev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it to kDLMAIA since the MAIA is the released name.

@tqchen
Copy link
Member

tqchen commented Dec 13, 2023

gentle ping @kyule7 :)

@kyule7 kyule7 changed the title [RFC] [DeviceType] Add support for MsNpu [RFC] [DeviceType] Add support for MAIA Jan 30, 2024
@kyule7
Copy link
Contributor Author

kyule7 commented Feb 5, 2024

Could anyone help merging this PR?

@tqchen
Copy link
Member

tqchen commented Feb 5, 2024

Thanks @kyule7 this is now merged

@tqchen tqchen merged commit 4c10fec into dmlc:main Feb 5, 2024
2 of 3 checks passed
@edgarriba
Copy link
Contributor

@tqchen worth to release ?

@leofang
Copy link
Contributor

leofang commented Feb 7, 2024

There're a few changes from the Array API side that we're wrapping up, would be nice to hold off a bit 🙂

@leofang
Copy link
Contributor

leofang commented Feb 13, 2024

btw I noticed the doc build CI has been failing for some time (perhaps before this PR). Fixing it in #136.

@kyule7
Copy link
Contributor Author

kyule7 commented Feb 23, 2024

@tqchen worth to release ?

@edgarriba Would like to apply this change in the dependent framework repos (pytorch and onnxruntime), would there be any chance to have a new release including this PR change?

@leofang
Copy link
Contributor

leofang commented Feb 23, 2024

Hi, v1.0rc is out a few days ago, could you give it a try?
https://github.com/dmlc/dlpack/releases/tag/v1.0rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants