[GraphBolt][io_uring] Use RAII to ensure queues are returned. #7680
Conversation
|
To trigger regression tests:
|
| available_queues_.pop_back(); | ||
| } | ||
| auto &io_uring_queue = io_uring_queue_[thread_id]; | ||
| auto [acquired_queue_handle, my_read_buffer2] = queue_source.get(); |
There was a problem hiding this comment.
I think I used my in another PR. Will fix it today.
| @@ -147,6 +146,68 @@ class OnDiskNpyArray : public torch::CustomClassHolder { | |||
| static inline std::mutex available_queues_mtx_; // available_queues_ mutex. | |||
| static inline std::vector<int> available_queues_; | |||
|
|
|||
| struct QueueAndBufferAcquirer { | |||
There was a problem hiding this comment.
Better to explain how the Acquirer works at the top of the class.
Use class for struct with methods, struct is reserved only for data structure.
There was a problem hiding this comment.
Which guideline says that struct is reserved only for C style data structures? If you can point it out, I can read it and learn why this is preferred. I normally like using struct when the first things I am writing are supposed to be public.
There was a problem hiding this comment.
https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes
We are trying to follow Google style guide for C++: https://docs.dgl.ai/contribute.html#coding-styles
Description
Make use of RAII to ensure the queues are returned back in a guaranteed way due to the object destructors.
This should make the code more error prone (I mean safer). Even if the worker threads or the main thread face an error or an exception, the destructors will be called, releasing the acquired shared resources.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes