Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Fix GPUCachedFeature docstring typo #7639

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

pyynb
Copy link
Collaborator

@pyynb pyynb commented Aug 2, 2024

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@Rhett-Ying
Copy link
Collaborator

@mfbalin FYI

@Rhett-Ying Rhett-Ying merged commit f1c28d3 into dmlc:master Aug 2, 2024
1 of 2 checks passed
@mfbalin
Copy link
Collaborator

mfbalin commented Aug 2, 2024

Does it always require us to say Examples for the codeblock to render?

Thank you very much for fixing this.

@pyynb
Copy link
Collaborator Author

pyynb commented Aug 2, 2024

Does it always require us to say Examples for the codeblock to render?

Thank you very much for fixing this.
Not using "examples" will cause the doc to display incorrectly.

image image

@mfbalin
Copy link
Collaborator

mfbalin commented Aug 2, 2024

Does it always require us to say Examples for the codeblock to render?
Thank you very much for fixing this.
Not using "examples" will cause the doc to display incorrectly.

image image

Why is the r prefix needed before the multiline string?

@pyynb
Copy link
Collaborator Author

pyynb commented Aug 2, 2024

Why is the r prefix needed before the multiline string?

Just in case there are escape characters in the string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants