Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphBolt] Add CPUCachedFeature. [2] #7537

Merged
merged 10 commits into from
Jul 19, 2024
Merged

[GraphBolt] Add CPUCachedFeature. [2] #7537

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf0d9dd
[GraphBolt] Add CPUCachedFeature.
mfbalin Jul 18, 2024
ea6f23c
remove test and open another PR
mfbalin Jul 18, 2024
35f0f27
move change to the other PR.
mfbalin Jul 18, 2024
82b4b3c
move change to the other PR.
mfbalin Jul 18, 2024
0145eae
remove unnecessary doc.
mfbalin Jul 18, 2024
50285e2
add type of last arg.
mfbalin Jul 18, 2024
e5a9bc4
refine documentation.
mfbalin Jul 18, 2024
4f2b098
put these changes to another PR.
mfbalin Jul 18, 2024
8749a25
Merge branch 'master' into gb_cpu_cached_feature
mfbalin Jul 19, 2024
9b5e58a
better name
mfbalin Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move change to the other PR.
  • Loading branch information
@mfbalin
mfbalin committed Jul 18, 2024
commit 82b4b3c8747ae264d9a508188d5b6d72f62a0c1f
7 changes: 0 additions & 7 deletions python/dgl/graphbolt/impl/feature_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,6 @@ def __init__(
), f"{list(caching_policies.keys())} are the available caching policies."
if num_parts is None:
num_parts = torch.get_num_threads()
min_num_cache_items = num_parts * (10 if policy == "s3-fifo" else 1)
# Since we partition the cache, each partition needs to have a positive
# number of slots. In addition, each "s3-fifo" partition needs at least
# 10 slots since the small queue is 10% and the small queue needs a
# positive size.
if cache_shape[0] < min_num_cache_items:
cache_shape = (min_num_cache_items,) + cache_shape[1:]
self._policy = caching_policies[policy](cache_shape[0], num_parts)
self._cache = torch.ops.graphbolt.feature_cache(
cache_shape, dtype, pin_memory
Expand Down
Loading