-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] Add gb.numpy_save_aligned
.
#7524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
Finished working on the PR. |
Rhett-Ying
reviewed
Jul 16, 2024
Rhett-Ying
reviewed
Jul 16, 2024
frozenbugs
reviewed
Jul 16, 2024
frozenbugs
approved these changes
Jul 16, 2024
Rhett-Ying
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we store our features in the numpy format using this new function, our io_uring and mmap disk read operations will speedup significantly (2.1 GiB/s vs 1.7 GiB/s) for nice close to power of 2 embedding sizes such as 768
float
s or 512int8
sIt is risk free to do this change because the files that we handle are a lot larger than 4K.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes