Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Sample neighbors synchronization optimization. #7264

Merged

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Apr 3, 2024

Description

Explanation is in the PR diff comments. I don't know why I didn't code it up like this in the first place.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs April 3, 2024 08:09
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 3, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin
Copy link
Collaborator Author

mfbalin commented Apr 3, 2024

This PR can be merged rather quickly as the optimization can be pretty significant. Homo sampling has 1 synchronization instead of 2 now.

@mfbalin mfbalin changed the title [GraphBolt][CUDA] Minor sample neighbors optimization. [GraphBolt][CUDA] Sample neighbors synchronization optimization. Apr 3, 2024
@mfbalin mfbalin requested a review from Rhett-Ying April 3, 2024 08:36
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 3, 2024

Commit ID: 4273f53

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 7eb4de4 into dmlc:master Apr 7, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_sample_neighbors_synchronization_opt branch April 7, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants