Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Implement dependent minibatching for labor. #7205

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Mar 9, 2024

Description

The continuous seed file is mostly a copy of https://github.com/dmlc/dgl/blob/master/src/random/continuous_seed.h.

These changes are needed to implement the layer_dependency and batch_dependency arguments in https://docs.dgl.ai/en/latest/generated/dgl.dataloading.LaborSampler.html#dgl.dataloading.LaborSampler. They will be enabled in a future PR.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs March 9, 2024 05:56
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2024

Commit ID: 869a980

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Mar 9, 2024

@dgl-bot run g4dn.8xlarge model,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2024

Commit ID: 869a980

Build ID: 2

Status: ❌ CI test failed in Stage [Regression Test].

Report path: link

Full logs path: link

@451578928
Copy link

451578928 commented Mar 9, 2024 via email

@mfbalin
Copy link
Collaborator Author

mfbalin commented Mar 9, 2024

@frozenbugs How do I run the regression tests to ensure this PR is not slowing down the CPU layer_neighbor implementation?

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2024

Commit ID: 8b1a19d

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

frozenbugs commented Mar 11, 2024

@frozenbugs How do I run the regression tests to ensure this PR is not slowing down the CPU layer_neighbor implementation?

Just merge the code, and the result will be send out tomorrow to you. If any unexpected happens, we can revert this PR.

@mfbalin mfbalin merged commit f0c7efa into dmlc:master Mar 11, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_labor_knobs branch March 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants