[Tools] use torchrun instead of torch.distributed.launch #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in cleanup_proc
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
@Rhett-Ying I kindly ask to review this pull request. |
|
@9rum Thanks for filing this PR. have your verified in your local? |
|
please update test cases like dgl/tests/tools/test_launch.py Line 24 in ce8a7dd |
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
@Rhett-Ying Thanks for your kind reply. ......
----------------------------------------------------------------------
Ran 6 tests in 0.000s
OKIn addition to the above unit test, I have confirmed that the changes work well with the official distributed GraphSAGE training example. |
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
peizhou001
pushed a commit
to peizhou001/dgl
that referenced
this pull request
Nov 27, 2023
DominikaJedynak
pushed a commit
to DominikaJedynak/dgl
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes future warning from
torch.distributed.launch(discussed in issue #5493) with minor fix typo.The
torch.distributed.launchmodule is deprecated and it always printsFutureWarning: The module torch.distributed.launch is deprecated and will be removed in future. Use torchrun..Note that the typo issue from
--local-rankargument is already fixed.Changes
torchruninstead oftorch.distributed.launch: The aforementioned deprecation warning is eliminated.cleanup_proc:cleanup_procno longer prints misspelled message.