Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Fused sampling with compaction #5924

Merged
merged 10 commits into from
Jul 20, 2023
Merged

[Performance] Fused sampling with compaction #5924

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7b8b937
Fused sampling
agrabow Jun 28, 2023
646a528
Replace non-constant references with pointers.
agrabow Jun 28, 2023
2afa96d
Fix neighbor.py lint issues
agrabow Jun 28, 2023
7a345c5
Create Windows path with atomic operation
agrabow Jun 29, 2023
e1494d7
Add backend checks for PyTorch only
agrabow Jun 30, 2023
805f786
Fix test_sample_neighbors_mask
agrabow Jun 30, 2023
a4349eb
Update fused neighbor sampling dispatch
agrabow Jul 3, 2023
326ba0e
Replace type() with isinstance()
agrabow Jul 3, 2023
ce0d545
Create sample_neighbors_fused() python function
agrabow Jul 17, 2023
8ae7ab6
Update benchmark fused sampling
agrabow Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix neighbor.py lint issues
  • Loading branch information
@agrabow
agrabow committed Jul 19, 2023
commit 2afa96dec4b1250139d15d454c7010fa0aea742b
4 changes: 2 additions & 2 deletions python/dgl/sampling/neighbor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from .. import backend as F, ndarray as nd, utils
from .._ffi.function import _init_api
from ..base import DGLError, EID, NID
from ..base import DGLError, EID
from ..heterograph import DGLBlock, DGLGraph
from .utils import EidExcluder

Expand Down Expand Up @@ -478,7 +478,7 @@ def _sample_neighbors(
if F.device_type(g.device) != "cpu":
raise DGLError("Only cpu is supported in fused sampling")

if mapping == None:
if mapping is None:
mapping = {}
mapping_name = "__mapping" + str(os.getpid())
if mapping_name not in mapping.keys():
Expand Down