Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Implemented SubgraphX Explainer for Homogeneous graph #4913

Closed
wants to merge 140 commits into from
Closed

[Model] Implemented SubgraphX Explainer for Homogeneous graph #4913

wants to merge 140 commits into from

Conversation

kunmukh
Copy link
Contributor

@kunmukh kunmukh commented Nov 16, 2022

Description

Implemented SubgraphX Explainer (https://arxiv.org/pdf/2102.05152.pdf) for Homogeneous Graphs

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (for example, test, and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

  • Added a new class, SubgraphXExplainer for homogeneous graph explanation.

The output of the model has been manually verified on MUTAG dataset. Unfortunately, there's no ground truth for the explanation, so we cannot quantify the model's performance. Instead, we manually investigated the results and confirmed that they aligned well with human intuition.

Inline documentation is added following the original style, and an example of using the module is included in the documentation.

moeinfinityx and others added 30 commits August 15, 2022 19:35
* add HeteroGNNExplainer

* GNNExplainer for heterogeenous graph

* fix typo

* variable name cleanup
Change DGLHeteroGraph to DGLGraph, and specified parameter inputs
…ppriopiate places to be consistent with existing practices
…ppriopiate places that were missed in the last commit
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 15, 2023

Commit ID: 70fe23bc95fc4be1e9708298e6147e90912eb831

Build ID: 65

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 15, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 15, 2023

Commit ID: f201b69

Build ID: 66

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@@ -91,7 +91,7 @@ def __init__(
model,
num_hops,
coef=10.0,
high2low=False,
high2low=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change the parameter description above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@mufeili
Copy link
Member

mufeili commented Feb 16, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Commit ID: 730296f

Build ID: 67

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Feb 16, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Commit ID: 65975a5

Build ID: 69

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Commit ID: 730296f

Build ID: 68

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Feb 16, 2023

The tests failed with

>           largest_cc_nids = subg.ndata[NID][largest_cc_nids].sort().values
E           IndexError: tensors used as indices must be long, byte or bool tensors

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Commit ID: 65975a5

Build ID: 70

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Commit ID: 68535200ef20c8bc23a0bf566aa12ab63b22b210

Build ID: 71

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 16, 2023

Commit ID: b8ba443

Build ID: 72

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 17, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 17, 2023

Commit ID: d380df0

Build ID: 73

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Feb 17, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 17, 2023

Commit ID: d380df0

Build ID: 74

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Feb 17, 2023

It seems that this PR is never successfully built. I suspect there is something wrong with your fork/branch. Perhaps you should create a new fork from the latest DGL and move your code to that new fork. @kunmukh

@kunmukh
Copy link
Contributor Author

kunmukh commented Feb 17, 2023

New PR: #5315 . Therefore, closing this one. A new PR was created because the old PR test directory was re-structured and the test pipeline failed.

@kunmukh kunmukh closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants