-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createCharge fails on Bitcoin payments from Checkout.js #49
Comments
And to be clear, I don't necessarily propose the above patch as an actual fix. A real fix would be a bit more involved. If the |
See dmjio#49 Signed-off-by: Austin Seipp <[email protected]>
Thanks for bringing this issue to light. While it is shocking that a
cc: @stepcut |
This works around dmjio/stripe#49 Signed-off-by: Austin Seipp <[email protected]>
Oh, and actually I'm not 100% sure if that patch alone fixes it... It seems like it does, and I can receive donations when I look in the dashboard (I see the charge) -- but then Stripe sends an email shortly afterwords saying something went wrong, and they're offering a refund with a URL to follow (even though I'm in test mode already?!) I have no clue why just yet, but I haven't tried it out of test mode, either. From memory I don't think it should happen. I'll maybe drop by their IRC channel to see if I can figure anything out, and look at my dashboard HTTP logs. I'll follow up with this after. |
Hmm that's strange, unsure why |
cc @matthewarkin if you have any insight as to why donations would behave differently would be appreciated :) @thoughtpolice, https://support.stripe.com/questions/does-stripe-offer-a-fee-discount-for-non-profit-organizations wonder if API calls would be altered depending on organization status. |
Actually, I think I figured it out. It was because you have to actually enable live Bitcoin transfers in your account, which requires to agreeing to a few extra TOS about conversions, etc. Maybe? I guess this even applies in test mode. Since I enabled that I don't think I've gotten any more emails, and my prior ones actually do look OK (the Dashboard says the API responded with 200 to charges with Bitcoin |
@thoughtpolice, ah, makes sense I guess. I bet we could provide a test for this too. I can append it to your PR |
As long as we can create a token corresponding to a bitcoin transaction, it should be testable. |
Bitcoin charges come in the form of
|
Well that looks promising to me :) but yes, additional info would help. Might also want to let stripe know about the 501(c)3 status, it seems there is a small fee on bitcoin transactions. Re:Bitcoin, docs also talk about a |
This lib is due for an upgrade anyways, |
Any news on this? @dmjio @thoughtpolice |
@thoughtpolice, hai :)
Is haskell.org still using your fork of this lib? |
Yes, but I haven't deployed it yet because busy. The patch is still the same, and the source is here: https://github.com/thoughtpolice/haskell-donate/ |
In |
If Checkout.js is used to generate a
TokenId
which was created using the Bitcoin option (see here), thencreateCharge
will fail.The Stripe API endpoint does not respond with a
card
field inside theCharge
object when the charge is made with Bitcoin. As a result, theCharge
FromJSON
instance fails to parse the object. This results in a charge that looks like it fails due to some API error in the library, but has actually succeeded just fine and looks perfectly OK in the Stripe logs.This is in some sense related to #19. I would really like to see these issues fixed, because I'd like to use this library on the new Haskell.org donation site without having to use a fork. :(
I've fixed both of these issues in my own private fork. Here's the full patch:
The text was updated successfully, but these errors were encountered: