Merge branch 'master' into master

dmitrirussu · Jun 15, 2024 · 7634748 · 7634748
2 parents 3263599 + 74c902d
commit 7634748
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/composer.json b/composer.json
@@ -26,6 +26,8 @@
  "cmpayments/iban": "^1.1"
  },
  "require-dev": {
- "phpunit/phpunit": "^8.3"
+ "phpunit/phpunit": "^8.3",
+ "ext-bcmath": "*",
+ "ext-mbstring": "*"
  }
 }
diff --git a/src/PaymentInfo.php b/src/PaymentInfo.php
@@ -507,7 +507,7 @@ public function setCreditorSchemeIdentification($creditorSchemaId)
  if (empty($creditorSchemaId) || is_null($creditorSchemaId)) {
  throw new \Exception(ERROR_MSG_PM_CREDITOR_SCHEME_IDENTIFICATION);
  }
- $this->CreditorSchemeIdentification = $creditorSchemaId;
+ $this->creditorSchemeIdentification = $creditorSchemaId;
  return $this;
  }
 
@@ -943,8 +943,8 @@ protected function addCreditorFieldsToXml(\SimpleXMLElement $paymentInfo)
  $privateIdentification = $creditorSchemeIdentificationID->addChild('PrvtId');
  $othr = $privateIdentification->addChild('Othr');
 
- if (!empty($this->CreditorSchemeIdentification)) {
- $othr->addChild('Id', $this->CreditorSchemeIdentification);
+ if (!empty($this->creditorSchemeIdentification)) {
+ $othr->addChild('Id', $this->creditorSchemeIdentification);
  }
 
  $schemeName = $othr->addChild('SchmeNm');

diff --git a/src/ValidationRules.php b/src/ValidationRules.php
@@ -131,7 +131,7 @@ public function checkStringLength($value, $length = 0)
  * @return bool
  * @throws \Exception
  */
- public function validation($xmlSEPAFile = null, $xsdPainRule)
+ public function validation($xmlSEPAFile, $xsdPainRule)
  {
  if (empty($xmlSEPAFile) && !file_exists($xmlSEPAFile)) {
  throw new \InvalidArgumentException('Missing SEPA XML File');