Update eslint-plugin-jsx-a11y to version 5.0.0 🚀 #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
eslint-plugin-jsx-a11y just published its new version 5.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint-plugin-jsx-a11y.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
[breaking] Refactor
img-has-altrule intoalt-textrule[breaking] Rule
onclick-has-roleis removed. Replaced withno-static-element-interactionsandno-noninteractive-element-interactions.[breaking] Rule
onclick-has-focusis removed. Replaced withinteractive-supports-focus.[new] - Add rule
media-has-captionrule[new] - Add
ignoreNonDOMoption tono-autofocus.[new] - Add rule
no-interactive-element-to-noninteractive-role[new] - Add rule
no-noninteractive-element-to-interactive-role[new] - Add rule
no-noninteractive-tabindex[new] - Configs split into "recommended" and "strict".
[enhanced] - Configuration options added to
no-static-element-interactionsandno-noninteractive-element-interactions. Options allow for fine-tuning of elements and event handlers to check.The new version differs by 210 commits .
ca876d25.0.0bb8dc4dUpdate CHANGELOG for v5.24b6193Refactor img-has-alt to alt-text (#220)5be6cd6Merge pull request #221 from jessebeach/docs--no-noninteractive-element-interactions68931f3Add a case for interaction handlers on table cells to no-noninteractive-element-interactions6be5eabMerge pull request #218 from jessebeach/options-for-interactive-element-rulesacb6f31Adding documentation to interactive rule docs71299a0Convert options to object from arrayed0074dResponding to review comments; remove unnecessary assignmentf91fa08Add options to element interaction rulesa36d8b0Merge pull request #210 from jessebeach/no-noninteractive-tabindex1b063ceResponding to feedback about test schema definition48c1890Fixing lint errors.35370e0Adding tag and role config overrides to no-noninteractive-tabindex rule.aca0eabAdding no-noninteractive-tabindex to READMEThere are 210 commits in total. See the full diff.