split AttributeViolation into two distinct uses #17088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17088" |
|
Mind the CI failures |
|
This is what I get for trying to develop without an internet connection. |
b1429e5
to
82c7de2
Compare
82c7de2
to
deede07
Compare
deede07
to
c36ef39
Compare
thewilsonator
approved these changes
Nov 24, 2024
|
Aaaaand stripping away everything else revealed the glaring bug - a copy/pasta mistake I made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing effort to split the undocumented and complex use of null formats and null arg0.
Also changed
fmtandfmtStrintoformatfor consistency.Split fields of AttributeViolation into two distinct groups, using a constructor for each.