Skip to content

Commit

Permalink
Fix for missing l2 to l1 messages (0xSpaceShard#330)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikiw committed Nov 3, 2022
1 parent e353f24 commit 33ef003
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion starknet_devnet/transactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def __get_l2_to_l1_messages(self) -> List[L2ToL1Message]:

contract_address = self.execution_info.call_info.contract_address

for l2_to_l1_message in self.execution_info.call_info.l2_to_l1_messages:
for l2_to_l1_message in self.execution_info.get_sorted_l2_to_l1_messages():
l2_to_l1_messages.append(
L2ToL1Message(
from_address=contract_address,
Expand Down
11 changes: 9 additions & 2 deletions test/test_postman.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,17 +216,24 @@ def _l1_l2_message_exchange(web3, l1l2_example_contract, l2_contract_address):
assert balance == 0

# withdraw in l1 and assert contract balance
withdraw_amount = 1000
web3_transact(
web3,
"withdraw",
l1l2_example_contract,
int(l2_contract_address, base=16),
USER_ID,
1000,
withdraw_amount,
)

# Check if l2 to l1 message is included in transaction_receipts
l2_to_l1_block = get_block(parse=True)
l2_to_l1_messages = l2_to_l1_block["transaction_receipts"][0]["l2_to_l1_messages"]
l2_to_l1_withdraw_amount = l2_to_l1_messages[0]["payload"][2]
assert l2_to_l1_withdraw_amount == hex(withdraw_amount)

balance = web3_call("userBalances", l1l2_example_contract, USER_ID)
assert balance == 1000
assert balance == withdraw_amount

# assert l2 contract balance
l2_balance = call(
Expand Down

0 comments on commit 33ef003

Please sign in to comment.