forked from apache/fineract
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add Merge Strategy section to README (apache#1284)
includes improved PR Template (and move commit message blurb in README)
- Loading branch information
Showing
2 changed files
with
26 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,24 @@ | ||
## Description | ||
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket | ||
|
||
Describe the changes made and why they were made. | ||
|
||
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). | ||
|
||
|
||
## Checklist | ||
|
||
Please make sure these boxes are checked before submitting your pull request - thanks! | ||
|
||
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. | ||
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests | ||
|
||
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. | ||
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. | ||
|
||
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes. | ||
- [ ] Create/update unit or integration tests for verifying the changes made. | ||
|
||
- [ ] Integration tests have been created/updated for verifying the changes made. | ||
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. | ||
|
||
- [ ] All Integrations tests are passing with the new commits. | ||
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes | ||
|
||
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) | ||
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) | ||
|
||
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide | ||
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters